[U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage

Wolfgang Denk wd at denx.de
Tue Nov 18 10:55:44 CET 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081118093437.GL20874 at game.jcrosoft.org> you wrote:
>
> > >  #ifdef CONFIG_OF_LIBFDT
> > > +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
> > 
> > This change seems wrong to me. There are PPC systems which do not use
> > the device tree - why should we enable this code for these?
> thats already the case by the ifdef CONFIG_OF_LIBFDT

Sorry for not being clear (or correct).

What I mean is: if this code should not be enabled on  some  systems,
even though CONFIG_OF_LIBFDT is set, then we should make it depend on
some  property which only gets set for these boards, but not globally
for the whole architecture.

I still do not understand what such a property would be  in  addition
to LIBFDT support?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Misquotation is, in fact, the pride and privilege of the  learned.  A
widely-read  man  never  quotes  accurately,  for  the rather obvious
reason that he has read too widely.
                - Hesketh Pearson _Common Misquotations_ introduction


More information about the U-Boot mailing list