[U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage

[Kumar Gala]

On Nov 18, 2008, at 3:55 AM, Wolfgang Denk wrote:

> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20081118093437.GL20874 at game.jcrosoft.org> you wrote:
>>
>>>> #ifdef CONFIG_OF_LIBFDT
>>>> +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) ||  
>>>> defined(CONFIG_SPARC)
>>>
>>> This change seems wrong to me. There are PPC systems which do not  
>>> use
>>> the device tree - why should we enable this code for these?
>> thats already the case by the ifdef CONFIG_OF_LIBFDT
>
> Sorry for not being clear (or correct).
>
> What I mean is: if this code should not be enabled on  some  systems,
> even though CONFIG_OF_LIBFDT is set, then we should make it depend on
> some  property which only gets set for these boards, but not globally
> for the whole architecture.
>
> I still do not understand what such a property would be  in  addition
> to LIBFDT support?

I think the commit message needs more explanation about use of LIBFDT  
for FIT vs use of LIBFDT for actual system boot device tree usage.

- k