[U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage
Wolfgang Denk
wd at denx.de
Tue Nov 18 14:16:28 CET 2008
Dear Kumar Gala,
In message <38EEA926-C235-4A1B-AE50-437E58C29F3B at kernel.crashing.org> you wrote:
>
> >>>> #ifdef CONFIG_OF_LIBFDT
> >>>> +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) ||
> >>>> defined(CONFIG_SPARC)
...
> > I still do not understand what such a property would be in addition
> > to LIBFDT support?
>
> I think the commit message needs more explanation about use of LIBFDT
> for FIT vs use of LIBFDT for actual system boot device tree usage.
Agreed. And any such dependencies should be coded for CONFIG_FIT, not
for "CONFIG_PPC || CONFIG_M68K || CONFIG_SPARC" - this has nothing to
do with any specific processor architectures. [Existing code that
already uses such broken code should be cleaned up, too.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
: 1. What is the possibility of this being added in the future?
In the near future, the probability is close to zero. In the distant
future, I'll be dead, and posterity can do whatever they like... :-)
- lwall
More information about the U-Boot
mailing list