[U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not

Wolfgang Denk wd at denx.de
Wed Nov 19 14:10:59 CET 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081119121016.GB30468 at game.jcrosoft.org> you wrote:
>
> > > +#if defined(CONFIG_PPC) || defined(CONFIG_M68K)
> > 
> > Maybe "|| defined(CONFIG_SPARC)" is missing here?
> no this function is only use on PPC and M68K bootm

Then, again, we should add a feature-specific #define here, but not an
architecture specific one.

> > > -COBJS-$(CONFIG_OF_LIBFDT) += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
> > > +COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
> > > +
> > > +COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
> > > +COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
> > > +
> > 
> > Would it not be easier to just add a line
> > 
> > COBJS-$(CONFIG_FIT) += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
> > 
> > ?
> no because we may do not have the CONFIG_OF_LIBFDT and CONFIG_FIT at the same
> time

Yes, of course we may have both at the same time.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Just about every computer on the market today runs Unix,  except  the
Mac (and nobody cares about it).                   - Bill Joy 6/21/85


More information about the U-Boot mailing list