[U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Wed Nov 19 14:22:30 CET 2008
On 14:10 Wed 19 Nov , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20081119121016.GB30468 at game.jcrosoft.org> you wrote:
> >
> > > > +#if defined(CONFIG_PPC) || defined(CONFIG_M68K)
> > >
> > > Maybe "|| defined(CONFIG_SPARC)" is missing here?
> > no this function is only use on PPC and M68K bootm
>
> Then, again, we should add a feature-specific #define here, but not an
> architecture specific one.
I'll think of 2 new CONFIG so
>
> > > > -COBJS-$(CONFIG_OF_LIBFDT) += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
> > > > +COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
> > > > +
> > > > +COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
> > > > +COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
> > > > +
> > >
> > > Would it not be easier to just add a line
> > >
> > > COBJS-$(CONFIG_FIT) += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
> > >
> > > ?
> > no because we may do not have the CONFIG_OF_LIBFDT and CONFIG_FIT at the same
> > time
>
> Yes, of course we may have both at the same time.
with my modification
I'd like to support the 3 following configurations :
1) FIT only CONFIG_FIT
2) fdt blob only CONFIG_OF_LIBFDT
3) both CONFIG_OF_LIBFDT & CONFIG_FIT
so CONFIG_FIT could have CONFIG_FIT without CONFIG_OF_LIBFDT
Best Regards,
J.
More information about the U-Boot
mailing list