[U-Boot] [83xx] [RFC] Widening the scope of u-boot/cpu/mpc83xx/cpu.c : upmconfig

Kim Phillips kim.phillips at freescale.com
Thu Oct 16 00:47:39 CEST 2008


On Wed, 15 Oct 2008 17:35:39 -0400
richardretanubun <richardretanubun at ruggedcom.com> wrote:

> Two questions:
> 1. Can the CONFIG_MPC834X limitation be relaxed? (I am using an MPC8360E), If so, what should it be? CONFIG_83XX?
> 2. Can the #else action be changed from a printf to a #error? Something like this, maybe?
> 
> #else
>     #error upmconfig function not defined for this configuration.
> #endif
> 
> This alerts earlier during compile and not a hang during run time.
> 
> Please let me know what you think and I can submit a patch for it.

I think upmconfig code should be common for 83xx, 85xx, and 86xx and
put in a common area such as cpu/mpc8xxx once and for all.

but for now we (mpc83xx) can lose the #ifdef completely.

Patches addressing either of the above are welcome :).

Kim


More information about the U-Boot mailing list