[U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

[Wolfgang Denk]

Dear Guennadi Liakhovetski,

In message <Pine.LNX.4.64.0810231057420.4977 at axis700.grange> you wrote:
> 
> > Hey, actually I do think that describing which hardware configurations
> > the software performs is a Good Thing (TM).
> 
> Exactly, "which hardware configurations the software performs", XSELNAND 
> is not performed in software, this is just a pin you wire high or low on 
> your board. That's why I said we might not need to comment upon it. That's 
> how I interpreted the datasheet anyway.

I don;t think how this would make a difference. Even if the signal is
defined by the hardware dsign - the very moment I am referencing this
signal in any piece of software I should explain it so the reader of
the code understands what I'm doing.

Using meaningful names instead of magic numbers is a minimum to do.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It ain't so much the things we don't know that get  us  in  trouble.
It's  the  things  we know that ain't so." - Artemus Ward aka Charles
Farrar Brown