[U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

Guennadi Liakhovetski lg at denx.de
Thu Oct 23 11:23:37 CEST 2008


On Thu, 23 Oct 2008, Wolfgang Denk wrote:

> Dear Guennadi Liakhovetski,
> 
> In message <Pine.LNX.4.64.0810231057420.4977 at axis700.grange> you wrote:
> > 
> > > Hey, actually I do think that describing which hardware configurations
> > > the software performs is a Good Thing (TM).
> > 
> > Exactly, "which hardware configurations the software performs", XSELNAND 
> > is not performed in software, this is just a pin you wire high or low on 
> > your board. That's why I said we might not need to comment upon it. That's 
> > how I interpreted the datasheet anyway.
> 
> I don;t think how this would make a difference. Even if the signal is
> defined by the hardware dsign - the very moment I am referencing this
> signal in any piece of software I should explain it so the reader of
> the code understands what I'm doing.

I don't think this pin is referenced in software, at least not in this 
register, AFAICS. The only reason why Kyungmin mentioned it and why it is 
mentioned in the datasheet in the description of this register, is that 
this pin defines the selection between NAND and OneNAND - along with some 
other pins (OM[4:1] or some such). So, you cannot set this pin in 
software, you cannot read this pin in software (I think), maybe you have 
to switch a jumper when selecting another configuration, but that again 
has little to do with software, IMHO.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list