[U-Boot] [PATCH V2] board support patch for phyCORE-MPC5200B-tiny

[Jon Smirl]

On Sun, May 31, 2009 at 6:11 PM, Wolfgang Denk <wd at denx.de> wrote:
>> +/*---------------------------------------------------------------------------
>> + Environment settings
>> +---------------------------------------------------------------------------*/
>> +#if 0
>> +#define CONFIG_ENV_IS_IN_FLASH       1
>> +#define CONFIG_ENV_ADDR              (CONFIG_SYS_FLASH_BASE + 0xfe0000)
>> +#define CONFIG_ENV_SIZE              0x20000
>> +#define CONFIG_ENV_SECT_SIZE 0x20000
>> +#else
>> +#define CONFIG_ENV_IS_IN_EEPROM      1
>> +#define CONFIG_ENV_OFFSET    0x00    /* environment starts at the */
>> +                                     /*beginning of the EEPROM */
>> +#define CONFIG_ENV_SIZE              CONFIG_SYS_EEPROM_SIZE
>> +#endif
>> +#define CONFIG_ENV_OVERWRITE 1
>
> Are you sure? This is pessimal choice. EEPROM is slow and unreliable.
>
> After you decided for a solution, then please remove the (then) dead
> code.

Phytec ships default with the boards using the EEPROM.
But, I'm with you and I flip the #if to use the FLASH.

Both FLASH and EEPROM work. The flash has 128KB page size which wastes
a lot of space holding a 2KB environment so I see why some people want
to stick with EEPROM.

So I'd like to keep them both in place. Would it be better if the
FLASH section was a comment?


-- 
Jon Smirl
jonsmirl at gmail.com