[U-Boot] [PATCH V2] board support patch for phyCORE-MPC5200B-tiny

[Wolfgang Denk]

Dear Jon Smirl,

In message <9e4733910905311659u5e7c77a2ld80b526149c0d56a at mail.gmail.com> you wrote:
>
> > Are you sure? This is pessimal choice. EEPROM is slow and unreliable.
> >
> > After you decided for a solution, then please remove the (then) dead
> > code.
> 
> Phytec ships default with the boards using the EEPROM.

Once in mainline, you might want to point Phytec to that new, current
and well tested code, so they can consoider switching to the mainline
version.

> But, I'm with you and I flip the #if to use the FLASH.

I also recommend to configure resndant environment.

> Both FLASH and EEPROM work. The flash has 128KB page size which wastes
> a lot of space holding a 2KB environment so I see why some people want
> to stick with EEPROM.

Yes, "wasting" 128  or even 256 k of flash for "just a few variables"
seems to be an expensive thing. But keep in mind that most 52xx
systems boot from 0xFFF00000, so the the last megabyte of flash
is an excellent place for this (and probably the device tree).

> So I'd like to keep them both in place. Would it be better if the
> FLASH section was a comment?

Indeed, a comment would be better.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you believe that feeling bad or worrying long enough will change a
past or future event, then you are residing on another planet with  a
different reality system.