[U-Boot] [PATCH 1/2] Create the S5PC100 SoC code under the cpu/arm_cortesa8/

[Dirk Behme]

Hi Riverful,

Kim, Heung Jun wrote:
> Signed-off-by: HeungJun, Kim <riverful.kim at samsung.com>
> 
> ---
> 
> This patch is the new processor - S5PC100's SoC code & headers.
> This patch consists of 2 files.
> 
> The First file is to create the new SoC code related with S5PC100
> application processor.
> It's located in ther cpu/arm_cortesa8/s5pc100.
> 
> The Second file is to create the new SoC header related with S5PC100
> application processor.
> It's located in ther include/asm-arm/s5pc100.
> 
> This file is the First.
> 
>  cpu/arm_cortexa8/s5pc100/Makefile     |   48 +++++++
>  cpu/arm_cortexa8/s5pc100/config.mk    |   36 ++++++
>  cpu/arm_cortexa8/s5pc100/cpu_init.S   |  196 +++++++++++++++++++++++++++++
>  cpu/arm_cortexa8/s5pc100/interrupts.c |  218 +++++++++++++++++++++++++++++++++
>  cpu/arm_cortexa8/s5pc100/speed.c      |  159 ++++++++++++++++++++++++
>  5 files changed, 657 insertions(+), 0 deletions(-)
>  create mode 100644 cpu/arm_cortexa8/s5pc100/Makefile
>  create mode 100644 cpu/arm_cortexa8/s5pc100/config.mk
>  create mode 100644 cpu/arm_cortexa8/s5pc100/cpu_init.S
>  create mode 100644 cpu/arm_cortexa8/s5pc100/interrupts.c
>  create mode 100644 cpu/arm_cortexa8/s5pc100/speed.c

...

Some general comments on this and the second patch:

Can you try to format your patch series that it looks like something

[PATCH 0/2] ARM Cortex A8: Add new target S5PC100 SoC
[PATCH 1/2] ARM Cortex A8: S5PC100: Add CPU files
[PATCH 2/2] ARM Cortex A8: S5PC100: Add header files

With Patch 0/2 containing *no* patch code, just the explanation:

-- cut --
This patch series adds the new ARM Cortex A8 based S5PC100's SoC code 
& headers. This patch consists of 2 files.

The First file is to create the new SoC code related with S5PC100 
application processor. It's located in ther cpu/arm_cortesa8/s5pc100.

The Second file is to create the new SoC header related with S5PC100
application processor. It's located in ther include/asm-arm/s5pc100.

This series depends on

http://lists.denx.de/pipermail/u-boot/2009-June/053623.html

and

http://lists.denx.de/pipermail/u-boot/2009-May/053490.html

-- cut --

Then with Patch 1/2:

-- cut --

Add CPU support for S5PC100.

Signed-off-by: HeungJun, Kim <riverful.kim at samsung.com>
---

  cpu/arm_cortexa8/s5pc100/Makefile     |   48 +++++++
  cpu/arm_cortexa8/s5pc100/config.mk    |   36 ++++++
...
-- cut --

(Note the explanation *before* the Signed-off-by and the ---)

Then with patch 2/2:

-- cut --

Add S5PC100 header files.

Signed-off-by: HeungJun, Kim <riverful.kim at samsung.com>
---

  include/asm-arm/arch-s5pc100/clock.h     |  137 +++++++
  include/asm-arm/arch-s5pc100/cpu.h       |  292 +++++++++++++++
...
-- cut --

Best regards

Dirk