[U-Boot] [PATCH 01/17] Blackfin: add support for embedding the environment into LDRs

[Wolfgang Denk]

Dear Mike Frysinger,

In message <1244960934-20887-2-git-send-email-vapier at gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>

"LDR" might be a term that is familiar to you, but it is not familiar
to me and porobaly not to many other (non-BF) users. Please chose a
Subject: that everybody can understand.

:
>  Makefile           |    1 +
>  blackfin_config.mk |    7 +++++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index aa4646f..7480e2e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -323,6 +323,7 @@ $(obj)u-boot.bin:	$(obj)u-boot
>  		$(OBJCOPY) ${OBJCFLAGS} -O binary $< $@
>  
>  $(obj)u-boot.ldr:	$(obj)u-boot
> +		$(obj)tools/envcrc --binary > $(obj)env-ldr.o
>  		$(LDR) -T $(CONFIG_BFIN_CPU) -c $@ $< $(LDR_FLAGS)
>  
>  $(obj)u-boot.ldr.hex:	$(obj)u-boot.ldr
> diff --git a/blackfin_config.mk b/blackfin_config.mk
> index 05077c8..00e3bfc 100644
> --- a/blackfin_config.mk
> +++ b/blackfin_config.mk
> @@ -23,6 +23,8 @@
>  
>  CONFIG_BFIN_CPU := $(strip $(subst ",,$(CONFIG_BFIN_CPU)))
>  CONFIG_BFIN_BOOT_MODE := $(strip $(subst ",,$(CONFIG_BFIN_BOOT_MODE)))
> +CONFIG_ENV_OFFSET := $(strip $(subst ",,$(CONFIG_ENV_OFFSET)))
> +CONFIG_ENV_SIZE := $(strip $(subst ",,$(CONFIG_ENV_SIZE)))
>  
>  PLATFORM_RELFLAGS += -ffixed-P5 -fomit-frame-pointer -mno-fdpic
>  PLATFORM_CPPFLAGS += -DCONFIG_BLACKFIN
> @@ -43,6 +45,11 @@ LDR_FLAGS += --bmode $(subst BFIN_BOOT_,,$(CONFIG_BFIN_BOOT_MODE))
>  LDR_FLAGS += --use-vmas
>  ifneq ($(CONFIG_BFIN_BOOT_MODE),BFIN_BOOT_BYPASS)
>  LDR_FLAGS += --initcode $(obj)cpu/$(CPU)/initcode.o
> +ifneq ($(CONFIG_BFIN_BOOT_MODE),BFIN_BOOT_UART)
> +ifneq ($(ENV_IS_EMBEDDED_CUSTOM),ENV_IS_EMBEDDED_CUSTOM)
> +LDR_FLAGS += --punchit $$(($(CONFIG_ENV_OFFSET))):$$(($(CONFIG_ENV_SIZE))):$(obj)env-ldr.o

This line is very long; I guess it makes not much sense to wrap it,
though?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can't evaluate a man by logic alone.
	-- McCoy, "I, Mudd", stardate 4513.3