[U-Boot] [PATCH 01/17] Blackfin: add support for embedding the environment into LDRs

Mike Frysinger vapier at gentoo.org
Sun Jun 14 13:18:36 CEST 2009


On Sunday 14 June 2009 06:51:11 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
>
> "LDR" might be a term that is familiar to you, but it is not familiar
> to me and porobaly not to many other (non-BF) users. Please chose a
> Subject: that everybody can understand.

well, just about every Blackfin user knows what LDRs are because they have to 
use them most of the time.  i'll update it to read loader files (LDRs).

> > +LDR_FLAGS += --punchit
> > $$(($(CONFIG_ENV_OFFSET))):$$(($(CONFIG_ENV_SIZE))):$(obj)env-ldr.o
>
> This line is very long; I guess it makes not much sense to wrap it,
> though?

yeah, the option has to be one argument with no whitespace.  wrapping it would 
prevent indentation and that'd be worse imo.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090614/feaf5445/attachment.pgp 


More information about the U-Boot mailing list