[U-Boot] [PATCH] flread: new command for reading indirect mapped flashes

Mike Frysinger vapier at gentoo.org
Tue Jun 30 21:01:11 CEST 2009

On Tuesday 30 June 2009 14:44:25 Mike Frysinger wrote:
> +	if (dst < CONFIG_SYS_SDRAM_BASE ||
> +	    (dst + size) > (CONFIG_SYS_SDRAM_BASE + CONFIG_SYS_MAX_RAM_SIZE)) {
> +		printf("Error: memory area %#08lx to %#08lx is not in RAM\n",
> +		       dst, dst + size);
> +		return 1;
> +	}

actually, now that i think about it and read the diff yet again, this check 
doesnt make sense.  if the user gives a bad address, that is their fault.  
this prevents reading of the flash into say on-chip data SRAMs on a Blackfin 
part, or into SRAM that is mapped into the async bank.

once Stefan (and anyone else) gets a chance to review, i'll post a new patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090630/24237e13/attachment.pgp 

More information about the U-Boot mailing list