[U-Boot] [PATCH 03/15] tools/Makefile: Build bmp_logo only when LCD or VIDEO logos are enabled

[Mike Frysinger]

On Wednesday 04 March 2009 18:58:42 Peter Tyser wrote:
> On Wed, 2009-03-04 at 18:48 -0500, Mike Frysinger wrote:
> > On Wednesday 04 March 2009 18:32:53 Peter Tyser wrote:
> > > Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> > > ---
> > >  tools/Makefile |  107
> > > +++++++++++++++++++++++++++++--------------------------- 1 files
> > > changed, 55 insertions(+), 52 deletions(-)
> > >
> > > diff --git a/tools/Makefile b/tools/Makefile
> > > index 991ad8b..09512ec 100644
> > > --- a/tools/Makefile
> > > +++ b/tools/Makefile
> > > @@ -21,57 +21,6 @@
> > >  # MA 02111-1307 USA
> > >  #
> > >
> > > -# Generated executable files
> > > -BIN_FILES-y += img2srec$(SFX)
> > > -BIN_FILES-y += mkimage$(SFX)
> > > -BIN_FILES-y += envcrc$(SFX)
> > > -BIN_FILES-y += ubsha1$(SFX)
> > > -BIN_FILES-y += gen_eth_addr$(SFX)
> > > -BIN_FILES-y += bmp_logo$(SFX)
> >
> > this patch seems to move a large chunk of code around in the file for no
> > real discernible reason ... maybe some unrelated changes got squashed
> > here ?
>
> I moved a chunk of code below the "include $(TOPDIR)/config.mk".  The
> config.mk includes the include/autoconf.mk file which is needed for
> conditional compilation.  I assumed it was necessary to include
> config.mk before referencing CONFIG_XXX values in the Makefile, so the
> change was intentional.  Maybe there's some "make magic" such that the
> the order of the inclusion of config.mk doesn't matter, but I thought
> this was more logical even if it wasn't absolutely necessary.

please split that out then, or do the move when you did the mondo convert to 
the -y syntax in the first place (since you were already touching every line).  
going by the subject line, there should be only like 2-4 lines changed in this 
patch.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090304/0c25575f/attachment.pgp