[U-Boot] [PATCH 03/15] tools/Makefile: Build bmp_logo only when LCD or VIDEO logos are enabled

Wolfgang Denk wd at denx.de
Sun Mar 8 23:51:23 CET 2009

Dear Peter Tyser,

In message <1236211122.27449.8.camel at localhost.localdomain> you wrote:
> I moved a chunk of code below the "include $(TOPDIR)/config.mk".  The
> config.mk includes the include/autoconf.mk file which is needed for
> conditional compilation.  I assumed it was necessary to include
> config.mk before referencing CONFIG_XXX values in the Makefile, so the
> change was intentional.  Maybe there's some "make magic" such that the
> the order of the inclusion of config.mk doesn't matter, but I thought
> this was more logical even if it wasn't absolutely necessary.

Then document this (in the commit message), please.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many companies that have made themselves dependent on [the  equipment
of  a  certain  major  manufacturer] (and in doing so have sold their
soul to the devil) will collapse under the sheer weight  of  the  un-
mastered complexity of their data processing systems.
          -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5

More information about the U-Boot mailing list