[U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

[Detlev Zundel]

Hi Heiko,

>> +#define GPIO_BASE  (u_char *)0x30400000
>>   
>
> should be
>
> #define GPIO_BASE  (u_char *)CONFIG_SYS_CS3_START

Fixed, thanks.

>> +#define SERIAL_PORT_BASE	(u_char *)0x80000000
>>   
>
> this should be
>
> #define SERIAL_PORT_BASE	(u_char *)CONFIG_SYS_CS2_START

Fixed, thanks.


[...]

>> +#define UART_MSR_DCD	0x80	/* Data Carrier Detect */
>> +#define UART_MSR_DSR	0x20	/* Data Set Ready */
>> +#define UART_MSR_CTS	0x10	/* Clear to Send */
>>   
>
> Are this not common 16xxx UART registers? If so, I think, they
> should go in include/ns16550.h ...

Ok, done.

I'm glad I posted this series of patches again with my name added.  On
the previous posting, the code unfortunately did not get this quality
review ;)

Cheers
  Detlev

-- 
Wenn ein Kopf und ein Buch zusammenstossen und es klingt hohl; ist
denn das allemal im Buche?
                               - Lichtenberg
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de