[U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0

[Detlev Zundel]

Hi Wolfgang,

> Dear Heiko & Detlev,
>
> In message <49C91E04.2020801 at denx.de> you wrote:
> ...
>> > +#define GPIO_BASE  (u_char *)0x30400000
>> >   
>> 
>> should be
>> 
>> #define GPIO_BASE  (u_char *)CONFIG_SYS_CS3_START
>
> or
> 	#define GPIO_BASE  ((u_char *)CONFIG_SYS_CS3_START)
> ?
>
>> > +#define SERIAL_PORT_BASE	(u_char *)0x80000000
>> >   
>> 
>> this should be
>> 
>> #define SERIAL_PORT_BASE	(u_char *)CONFIG_SYS_CS2_START
>
> or
> 	#define SERIAL_PORT_BASE	((u_char *)CONFIG_SYS_CS2_START)
> ? 

Yes, I agree.

Thanks
  Detlev

-- 
Ftpd never switches uid and euid, it uses setfsuid(2) instead. The
main reason is that uid switching has been exploited in several
breakins, but the sheer ugliness of uid switching counts too.
                                     -- pure-ftpd(8)
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de