[U-Boot] [PATCH v2 3/7] drivers/twserial: Add protocol driver for "three wire serial" interface.

Detlev Zundel dzu at denx.de
Thu Mar 26 10:33:12 CET 2009


Hi Wolfgang,

> Dear Detlev Zundel,
>
> In message <1237998478-18452-4-git-send-email-dzu at denx.de> you wrote:
>> This pretty unintelligent interface is used on some RTC chips.
>> 
>> Signed-off-by: Detlev Zundel <dzu at denx.de>
> ...
>> diff --git a/include/tws.h b/include/tws.h
>> new file mode 100644
>> index 0000000..bfa8d58
>> --- /dev/null
>> +++ b/include/tws.h
>> @@ -0,0 +1,47 @@
> ...
>> +#ifndef _TWS_H_
>> +#define _TWS_H_
>> +
>> +#ifndef TWS_SOFT_DECLARATIONS
>> +# if defined(CONFIG_MPC5xxx)
>> +#  define TWS_SOFT_DECLARATIONS \
>> + volatile ioport_t *iop = ioport_addr((immap_t *)CONFIG_SYS_IMMR, I2C_PORT);
>> +# else
>> +#  define TWS_SOFT_DECLARATIONS
>> +# endif
>> +#endif
>
> Indentation not by TAB.

Yes, intentionally so.  Indenting by TAB exceeds the available line
length.  Judging by this single line I felt non-breaking the line was
more important.

Can you please point me to the section in the CodingStyle regarding
indentation for macros?  I'd be much obliged.

Thanks
  Detlev

-- 
"It's amazing I won. I was running against peace, prosperity, and
incumbency."
  --  George H.W. Bush, 06/14/2001, talking to Swedish prime
      minister Goran Perrson, unaware that a live tv camera was still on
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list