[U-Boot] [PATCH v2 3/7] drivers/twserial: Add protocol driver for "three wire serial" interface.

[Detlev Zundel]

Hi Wolfgang,

>> In message <1237998478-18452-4-git-send-email-dzu at denx.de> you wrote:
>>> This pretty unintelligent interface is used on some RTC chips.
>>> 
>>> Signed-off-by: Detlev Zundel <dzu at denx.de>
>> ...
>>> diff --git a/include/tws.h b/include/tws.h
>>> new file mode 100644
>>> index 0000000..bfa8d58
>>> --- /dev/null
>>> +++ b/include/tws.h
>>> @@ -0,0 +1,47 @@
>> ...
>>> +#ifndef _TWS_H_
>>> +#define _TWS_H_
>>> +
>>> +#ifndef TWS_SOFT_DECLARATIONS
>>> +# if defined(CONFIG_MPC5xxx)
>>> +#  define TWS_SOFT_DECLARATIONS \
>>> + volatile ioport_t *iop = ioport_addr((immap_t *)CONFIG_SYS_IMMR, I2C_PORT);
>>> +# else
>>> +#  define TWS_SOFT_DECLARATIONS
>>> +# endif
>>> +#endif
>>
>> Indentation not by TAB.
>
> Yes, intentionally so.  Indenting by TAB exceeds the available line
> length.  Judging by this single line I felt non-breaking the line was
> more important.
>
> Can you please point me to the section in the CodingStyle regarding
> indentation for macros?  I'd be much obliged.

The point is moot.  Pondering over this piece of code it suddenly
occured to me that the best solution is simply to remove it entirely ;)

This really is a leftover from an in-between broken implementation of
the interface, so the removal in this case bears no consequences.

If no further feedback on the patch series arrive, I'll repost the whole
stack tomorrow again.

Thanks again
  Detlev

-- 
If you currently have a 32-bit UNIX system, you are advised to
trade it in for a 64-bit one sometime before the year 2106.
 -- Andrew S. Tanenbaum: Modern Operating Systems, 2nd Edition
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de