[U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR

Wolfgang Denk wd at denx.de
Tue May 5 13:19:20 CEST 2009


Dear Daniel Mack,

In message <20090505103623.GE22117 at buzzloop.caiaq.de> you wrote:
>
> > No, I disagree. I don't care at all about any out-of-tree ports  that
> > might  exist  anywhere.  I  will  not  waste  any  thoughts about the
> > eventual possibility that changes to the  mainline  U-Boot code might
> > cause problems in such out-of-tree ports. That's not our problem.
> 
> What we're facing here is a clear build breakage that occurs in a
> combination of valid configuration flags. It's not an out-of-tree port.

We don't test all possible combinations of valid configuration flags.
As long as nobody is affected, there is little urge to move.

But here the situation is different: it does affect an actual board
which is in mainline:

-> ./MAKEALL delta
Configuring for delta board...
usb.c: In function 'usb_cpu_init':
usb.c:46: error: 'UP2OCR' undeclared (first use in this function)
usb.c:46: error: (Each undeclared identifier is reported only once
usb.c:46: error: for each function it appears in.)
make[1]: *** [usb.o] Error 1

> I was just reporting that in order to help other who might face a
> similar problem.

I understand this, and I appreciate your help.

I just wanted to point out some limitations that affect code or
configurations that are not in mainline.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Each honest calling, each walk of life, has its own  elite,  its  own
aristocracy based on excellence of performance. - James Bryant Conant


More information about the U-Boot mailing list