[U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR

Daniel Mack daniel at caiaq.de
Fri May 8 00:50:14 CEST 2009


On Thu, May 07, 2009 at 11:02:34PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Can you please run a "git show 24e37645" again?
> > 
> > To me it seems that this commit
> > 
> > - removed the usage of UP2OCR from board/delta/delta.c
> > but also
> > - added the usage of UP2OCR to the new file cpu/pxa/usb.c
> > without defining it.
> > 
> > 
> > So the comment seems absolutely correct to me. Maybe I'm missing
> > something?
> It's me I mix the commit
> this commit 3ccbfb25f48a:Support for PXA27X UDC.
> brake the pxa support
> by removing the UP2OCR

I was just running 'git blame' on the file that broke the build and
pointed out the commit that added the line that made the trouble. I
don't see what shouldn't be correct about that?

Anyway, feel free to change the commit log if you like, I don't
care. Most important thing is that things get fixed.

Thanks,
Daniel



More information about the U-Boot mailing list