[U-Boot] [PATCHv2 3/4] omap3: replace all instances of gpmc config struct by one global

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed May 13 09:04:48 CEST 2009


On 07:26 Wed 13 May     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090512230224.GL479 at game.jcrosoft.org> you wrote:
> > > diff --git a/cpu/arm_cortexa8/omap3/mem.c b/cpu/arm_cortexa8/omap3/mem.c
> > > index aa15f94..079c848 100644
> > > --- a/cpu/arm_cortexa8/omap3/mem.c
> > > +++ b/cpu/arm_cortexa8/omap3/mem.c
> > > @@ -41,6 +41,8 @@ unsigned int boot_flash_sec;
> > >  unsigned int boot_flash_type;
> > >  volatile unsigned int boot_flash_env_addr;
> > >  
> > > +struct gpmc *gpmc_cfg;
> > please do not expose it directly
> > please use a function to get it
> 
> Isn't this just adding to the memory footprint for little or no
> benefit?
avoid overwrite of the pointer by never use it directly

Best Regards,
J.


More information about the U-Boot mailing list