[U-Boot] [PATCHv2 3/4] omap3: replace all instances of gpmc config struct by one global

Wolfgang Denk wd at denx.de
Fri May 15 22:08:44 CEST 2009


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090513070448.GD30859 at game.jcrosoft.org> you wrote:
>
> > > > +struct gpmc *gpmc_cfg;
> > > please do not expose it directly
> > > please use a function to get it
> > 
> > Isn't this just adding to the memory footprint for little or no
> > benefit?
> avoid overwrite of the pointer by never use it directly

Ah. If that's the only (potential) problem, then I vote against using
a function. 

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many seconds are there in a year? If I tell you there are 3.155 x
10^7, you won't even try to remember it. On the other hand, who could
forget that, to within half a percent, pi seconds is  a  nanocentury.
                                               -- Tom Duff, Bell Labs


More information about the U-Boot mailing list