[U-Boot] [RFC PATCH 1/2] sh: make lds more generic
Wolfgang Denk
wd at denx.de
Wed May 27 08:29:18 CEST 2009
Dear Nobuhiro Iwamatsu,
In message <29ab51dc0905262313h17934f09u904a4e7325207148 at mail.gmail.com> you wrote:
> 2009/5/14 Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>:
> > currently the sh lds need to sync the lds enty and TEXT_BASE manualy
> > and the reloc_dst is based on it
> >
> > instead provide it now from the ldflags
> >
> > tested on r2dplus
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > Cc: Nobuhiro Iwamatsu <iwamatsu.nobuhiro at renesas.com>
>
> Appilied these patch collection.
> Thank you!
Sorry, but I don't agree. The commit message is terrible.
"sh lds need to sync the lds enty" - what is that suppoosed to mean?
I insist on readable and understandable commit messages.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I perceive a possibility of an immediate chronological sequence of
events which includes a violence.
- Terry Pratchett, _The Dark Side of the Sun_
More information about the U-Boot
mailing list