[U-Boot] [PATCH] Marvell MV88F6281GTW_GE Board support

[Wolfgang Denk]

Dear Prafulla Wadaskar,

In message <1243626217-9232-7-git-send-email-prafulla at marvell.com> you wrote:
> This is Marvell's 88F6281_A0 based custom board developed
> for wireless access point product
> 
> This patch is tested for-
> 1. Boot from DRAM/SPI flash/NFS
> 2. File transfer using tftp and loadb
> 3. SPI flash read/write/erase
> 4. Booting Linux kernel and RFS from SPI flash
> 
> Reviewed-by: Ronen Shitrit <rshitrit at marvell.com>
> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> ---
>  MAKEALL                                         |    1 +
>  Makefile                                        |    3 +
>  board/Marvell/mv88f6281gtw_ge/Makefile          |   51 ++++++
>  board/Marvell/mv88f6281gtw_ge/config.mk         |   25 +++
>  board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c |  141 +++++++++++++++++
>  board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h |   36 +++++
>  include/configs/mv88f6281gtw_ge.h               |  188 +++++++++++++++++++++++
>  7 files changed, 445 insertions(+), 0 deletions(-)
>  create mode 100644 board/Marvell/mv88f6281gtw_ge/Makefile
>  create mode 100644 board/Marvell/mv88f6281gtw_ge/config.mk
>  create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c
>  create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h
>  create mode 100644 include/configs/mv88f6281gtw_ge.h

Entry in MAINTAINERS file is missing.


> diff --git a/include/configs/mv88f6281gtw_ge.h b/include/configs/mv88f6281gtw_ge.h
> new file mode 100644
> index 0000000..8735b9e
> --- /dev/null
> +++ b/include/configs/mv88f6281gtw_ge.h
...
> +/*
> + * Commands configuration
> + */
> +#define CONFIG_CMD_ENV
> +#define CONFIG_CMD_RUN
> +#define CONFIG_CMD_LOADB
> +#define CONFIG_CMD_NET
> +#define CONFIG_CMD_AUTOSCRIPT
> +#define CONFIG_CMD_MEMORY
> +#define CONFIG_CMD_BOOTD
> +#define CONFIG_CMD_SAVEENV
> +#define CONFIG_CMD_SF

Please sort such lists.

...
> +#define CONFIG_MTDPARTS			"spi0.0:512k(uboot),"	\
> +	"512k at 512k(psm), 2m at 1m(kernel),13m at 3m(rootfs)\0"

For readability, you might want to omit the redundant offet values
here.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You may call me by my name, Wirth, or by my value, Worth.
- Nicklaus Wirth