[U-Boot] [PATCH] Marvell Sheevaplug Board support

[Wolfgang Denk]

Dear Prafulla Wadaskar,

In message <1243626217-9232-8-git-send-email-prafulla at marvell.com> you wrote:
> Reference:
> http://plugcomputer.org/
> http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support
> 
> This patch is tested for-
> 1. Boot from DRAM/NAND flash
> 2. File transfer using tftp
> 3. NAND flash read/write/erase
> 4. Linux kernel and RFS Boot from NAND
> 
> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> ---
>  MAKEALL                               |    1 +
>  Makefile                              |    4 +-
>  board/Marvell/sheevaplug/Makefile     |   51 +++++++++
>  board/Marvell/sheevaplug/config.mk    |   25 +++++
>  board/Marvell/sheevaplug/sheevaplug.c |  135 +++++++++++++++++++++++
>  board/Marvell/sheevaplug/sheevaplug.h |   37 +++++++
>  include/configs/sheevaplug.h          |  192 +++++++++++++++++++++++++++++++++
>  7 files changed, 444 insertions(+), 1 deletions(-)
>  create mode 100644 board/Marvell/sheevaplug/Makefile
>  create mode 100644 board/Marvell/sheevaplug/config.mk
>  create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
>  create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
>  create mode 100644 include/configs/sheevaplug.h

Entry in MAINTAINERS missing.

...
> +/*
> + * Commands configuration
> + */
> +#define CONFIG_CMD_ENV
> +#define CONFIG_CMD_RUN
> +#define CONFIG_CMD_LOADB
> +#define CONFIG_CMD_NET
> +#define CONFIG_CMD_AUTOSCRIPT
> +#define CONFIG_CMD_MEMORY
> +#define CONFIG_CMD_BOOTD
> +#define CONFIG_CMD_SAVEENV
> +#define CONFIG_CMD_NAND

Please sort.

...
> +#define CONFIG_MTDPARTS			"orion_nand:512k(uboot),"	\
> +	"1m at 4m(psm), 3m at 1m(kernel),13m at 5m(rootfs) rw\0"

Do you really want to have such an unusal and unexpectad setup?

> +/*
> + * Ethernet Driver configuration
> + */
> +#ifdef CONFIG_CMD_NET
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_PING

I recommend to keep command definitions close together. Move up?

> +#define CONFIG_NETCONSOLE	/* include NetConsole support   */
> +#define CONFIG_NET_MULTI	/* specify more that one ports available */
> +#define	CONFIG_MII		/* expose smi ove miiphy interface */
> +#define CONFIG_KIRKWOOD_EGIGA	/* Enable kirkwood Gbe Controller Driver */
> +#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN	/* detect link using phy */
> +#define CONFIG_KIRKWOOD_EGIGA_PORTS	{1,0}	/* enable port 0 only */
> +#define CONFIG_PHY_BASE_ADR	0
> +#define CONFIG_ENV_OVERWRITE	/* ethaddr can be reprogrammed */
> +#endif /* CONFIG_CMD_NET */


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Perl already has an IDE.  It's called Unix.
                      -- Tom Christiansen in 375bd509 at cs.colorado.edu