[U-Boot] [PATCH v2] fsl_pci_init_port end-point initialization is broken
Mahajan Vivek-B08308
B08308 at freescale.com
Wed Nov 4 10:14:10 CET 2009
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Wednesday, November 04, 2009 1:14 PM
> To: Swarthout Edward L-SWARTHOU; Mahajan Vivek-B08308
> Cc: u-boot at lists.denx.de
> Subject: [PATCH v2] fsl_pci_init_port end-point
> initialization is broken
>
> commit 70ed869e broke fsl pcie end-point initialization.
> Returning 0 is not correct. The function must return the
> first free bus number for the next controller.
>
> fsl_pci_init() must still be called and a bus allocated even
> if the controller is an end-point.
>
> Signed-off-by: Ed Swarthout <Ed.Swarthout at freescale.com>
> Acked-by: Vivek Mahajan <vivek.mahajan at freescale.com>
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> ---
> Guys, I want to revert commit 70ed869e and replace it with
> this. There is no reason to pass in pci_ep we can determine
> that internally. I will also change the board code to use
> fsl_is_pci_agent and kill off is_fsl_pci_agent (post november
> u-boot release).
>
> Can one of you test this out.
Works fine on P2020RDB host/agent virtual network scenario pending
that hold off linux bringup on the PCIe host.
>
> - k
>
Thanks,
Vivek
More information about the U-Boot
mailing list