[U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs

Mike Rapoport mike.rapoport at gmail.com
Wed Nov 11 22:56:57 CET 2009


On Wed, Nov 11, 2009 at 5:18 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Wednesday 11 November 2009 03:03:01 Mike Rapoport wrote:
>> --- a/drivers/net/smc911x.h
>> +++ b/drivers/net/smc911x.h
>> @@ -480,8 +480,8 @@ static void smc911x_reset(struct eth_device *dev)
>>                       !(smc911x_reg_read(dev, PMT_CTRL) & PMT_CTRL_READY))
>>                       udelay(10);
>>               if (!timeout) {
>> -                     printf(DRIVERNAME
>> -                             ": timeout waiting for PM restore\n");
>> +                     printf("%s: timeout waiting for PM restore\n",
>> +                            dev->name);
>>                       return;
>>               }
>>       }
>
> these changes in general look good, but if you're going to modify the common
> header, you need to update the eeprom code as well to set up the name field

It seems that eeprom code is broken since commit
736fead8fdbf8a8407048bebc373cd551d01ec98: "Convert SMC911X Ethernet
driver to CONFIG_NET_MULTI API".
I'll try to come up with a fix, but I have no way to test it.

> -mike
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>



-- 
	Sincerely Yours,
		Mike.


More information about the U-Boot mailing list