[U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs

[Mike Frysinger]

On Wednesday 11 November 2009 16:56:57 Mike Rapoport wrote:
> On Wed, Nov 11, 2009 at 5:18 PM, Mike Frysinger wrote:
> > On Wednesday 11 November 2009 03:03:01 Mike Rapoport wrote:
> >> --- a/drivers/net/smc911x.h
> >> +++ b/drivers/net/smc911x.h
> >> @@ -480,8 +480,8 @@ static void smc911x_reset(struct eth_device *dev)
> >>                       !(smc911x_reg_read(dev, PMT_CTRL) &
> >> PMT_CTRL_READY)) udelay(10);
> >>               if (!timeout) {
> >> -                     printf(DRIVERNAME
> >> -                             ": timeout waiting for PM restore\n");
> >> +                     printf("%s: timeout waiting for PM restore\n",
> >> +                            dev->name);
> >>                       return;
> >>               }
> >>       }
> >
> > these changes in general look good, but if you're going to modify the
> > common header, you need to update the eeprom code as well to set up the
> > name field
> 
> It seems that eeprom code is broken since commit
> 736fead8fdbf8a8407048bebc373cd551d01ec98: "Convert SMC911X Ethernet
> driver to CONFIG_NET_MULTI API".

broken how ?  i recall it working ...

> I'll try to come up with a fix, but I have no way to test it.

any board that has a smc911x part can test this code easily.  it doesnt 
require an eeprom to be hooked up to the smc911x part.  you can still dump on-
chip registers as well as poke the eeprorm interface.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091111/d5e7a2a8/attachment.pgp