[U-Boot] [PATCH 1/4] ARM Add New Board GEC2410

[Wolfgang Denk]

Dear Hui Tang,

In message <f9f0f3cf0911172255n73b44b41if851e7f9cc05241b at mail.gmail.com> you wrote:
> Dear Wolfgang,
> 
> >> +PLATFORM_CPPFLAGS += -I$(TOPDIR)/board/gec/gec2410
> >
> > Why is this needed?
> 
> in /board/gec/gec2410/lowlevel_init.S, it includes "gec2410_mem.h",
> which is at $(TOPDIR)/board/gec/gec2410.

So it's in the same directory? Then this should not be needed.

> >> diff --git a/nand_spl/board/gec/gec2410/u-boot.lds b/nand_spl/board/gec/gec2410/u-boot.lds
> >> new file mode 100644
> >> index 0000000..5871f7e
> >> --- /dev/null
> >> +++ b/nand_spl/board/gec/gec2410/u-boot.lds
> >
> > This file seems to be unused. Why add it?
> 
> /nand_spl/board/gec/gec2410/Makefile needs it to generate
> /nand_spl/board/u-boot.lds

I see no reference in the Makefile?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

There were meetings. There were always meetings. And they were  dull,
which is part of the reason they were meetings. Dull likes company.
                                    - Terry Pratchett, _Making_Money_