[U-Boot] [PATCH] Move the preprocessor test for building flash.c to the Makefile.

[Mike Frysinger]

On Thursday 19 November 2009 12:38:42 Robert P. J. Day wrote:
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -152,7 +152,9 @@ COBJS-$(CONFIG_VFD) += cmd_vfd.o
>  COBJS-$(CONFIG_DDR_SPD) += ddr_spd.o
>  COBJS-$(CONFIG_HWCONFIG) += hwconfig.o
>  COBJS-$(CONFIG_CONSOLE_MUX) += iomux.o
> +#ifndef CONFIG_SYS_NO_FLASH
>  COBJS-y += flash.o
> +#endif
>  COBJS-$(CONFIG_CMD_KGDB) += kgdb.o
>  COBJS-$(CONFIG_KALLSYMS) += kallsyms.o
>  COBJS-$(CONFIG_LCD) += lcd.o

me thinks you did not test this and/or you dont know how Makefile's work 
and/or you forgot to remove debug comments.

regardless, obvious NACK
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091119/173841e0/attachment.pgp