[U-Boot] [PATCH] Move the preprocessor test for building flash.c to the Makefile.

[Robert P. J. Day]

On Thu, 19 Nov 2009, Mike Frysinger wrote:

> On Thursday 19 November 2009 12:38:42 Robert P. J. Day wrote:
> > --- a/common/Makefile
> > +++ b/common/Makefile
> > @@ -152,7 +152,9 @@ COBJS-$(CONFIG_VFD) += cmd_vfd.o
> >  COBJS-$(CONFIG_DDR_SPD) += ddr_spd.o
> >  COBJS-$(CONFIG_HWCONFIG) += hwconfig.o
> >  COBJS-$(CONFIG_CONSOLE_MUX) += iomux.o
> > +#ifndef CONFIG_SYS_NO_FLASH
> >  COBJS-y += flash.o
> > +#endif
> >  COBJS-$(CONFIG_CMD_KGDB) += kgdb.o
> >  COBJS-$(CONFIG_KALLSYMS) += kallsyms.o
> >  COBJS-$(CONFIG_LCD) += lcd.o
>
> me thinks you did not test this and/or you dont know how Makefile's work
> and/or you forgot to remove debug comments.
>
> regardless, obvious NACK
> -mike

  oh, crap, that's what i get for getting lazy and not paying
attention.  sorry.

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================