[U-Boot] [PATCH] Fix for Void function returning value in sbc35-a9g20

Wolfgang Denk wd at denx.de
Mon Nov 23 23:49:27 CET 2009


Dear Tom,

In message <4AE9BD13.5010001 at windriver.com> you wrote:
> s-paulraj at ti.com wrote:
> > From: Sandeep Paulraj <s-paulraj at ti.com>
> > 
> > Void function was returning 0 in the m41t94 rtc driver.
> > This makes it similar to m41t62 rtc driver.
> > 
> > Signed-off-by: Sandeep Paulraj <s-paulraj at ti.com>
> > ---
> >  drivers/rtc/m41t94.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/rtc/m41t94.c b/drivers/rtc/m41t94.c
> > index 02b41d9..5b665bb 100644
> > --- a/drivers/rtc/m41t94.c
> > +++ b/drivers/rtc/m41t94.c
> > @@ -120,5 +120,4 @@ void rtc_reset(void)
> >  	 * Could not be tested as the reset pin is not wired on
> >  	 * the sbc35-ag20 board
> >  	 */
> > -	return 0;
> >  }
> 
> Yes this does kill the warning.
> Ack-ed
> 
> pushed to arm/next.

Why next? This is a bug fix, isn't it? Let's include it now.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Niklaus Wirth has lamented that, whereas Europeans pronounce his name
correctly (Ni-klows Virt), Americans invariably mangle it into (Nick-
les Worth). Which is to say that Europeans  call  him  by  name,  but
Americans call him by value.


More information about the U-Boot mailing list