[U-Boot] [u-boot] [PATCH] imx27: make 26MHz clock input value selectable from config files.

[Wolfgang Denk]

Dear javier Martin,

In message <eedb5540910290053n75762fbue8a277b21b983e16 at mail.gmail.com> you wrote:
> Some boards like Freescale imx27-ipcam and Vista Silicon
> imx27_visstrim_m10 have 25MHz clocks connected to 26MHz input.
> 
> This patch allows this value to be specified from the board
> configuration file in the same way as it is done with 32KHz clock.
> 
> It does not break any existing board since its default value is 26MHz.
> Tested in imx27lite and imx27_visstrim_m10 board.

Sorry for the long delay.

> Signed-off-by: Javier Martin <javier.martin at vista-silicon.com>
> --
>  cpu/arm926ejs/mx27/generic.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/cpu/arm926ejs/mx27/generic.c b/cpu/arm926ejs/mx27/generic.c
> index da05c55..c26fc56 100644
> --- a/cpu/arm926ejs/mx27/generic.c
> +++ b/cpu/arm926ejs/mx27/generic.c
> @@ -26,7 +26,9 @@
>  #ifdef CONFIG_MXC_MMC
>  #include <asm/arch/mxcmmc.h>
>  #endif
> -
> +#ifndef CONFIG_MX27_CLK26M
> +#define CONFIG_MX27_CLK26M 26000000
> +#endif

I agree with the patch in general, but it seems very strange to me to
name the variable "CLK26M" when it could be, for example, 25M instead.

Please chose a better name and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You humans have that emotional need  to  express  gratitude.  "You're
welcome," I believe, is the correct response.
	-- Spock, "Bread and Circuses", stardate 4041.2