[U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable

Wolfgang Denk wd at denx.de
Fri Sep 4 23:59:00 CEST 2009


Dear Timur Tabi,

In message <1252099715-19255-1-git-send-email-timur at freescale.com> you wrote:
> The value of I2C_TIMEOUT in fsl_i2c.c has several problems.  First, it is
> defined as CONFIG_HZ/4, but it is used as a count of microseconds, so it makes
> no sense to derive it from a clock rate.  Second, the current value (250) is
> too low for some boards, so it needs to be increased.  Third, the timeout
> necessary for multiple-master arbitration is larger than the timeout for basic
> read/write operations, so we shouldn't have a single constant for both timeouts.
> Finally, it would be nice if we could override these values on a per-board
> basis.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
>  drivers/i2c/fsl_i2c.c |   24 ++++++++++++++++++++----
>  1 files changed, 20 insertions(+), 4 deletions(-)

Acked-by: Wolfgang Denk <wd at denx.de>


Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"This isn't brain surgery; it's just television."   - David Letterman


More information about the U-Boot mailing list