[U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable

[Peter Tyser]

On Fri, 2009-09-04 at 23:59 +0200, Wolfgang Denk wrote:
> Dear Timur Tabi,
> 
> In message <1252099715-19255-1-git-send-email-timur at freescale.com> you wrote:
> > The value of I2C_TIMEOUT in fsl_i2c.c has several problems.  First, it is
> > defined as CONFIG_HZ/4, but it is used as a count of microseconds, so it makes
> > no sense to derive it from a clock rate.  Second, the current value (250) is
> > too low for some boards, so it needs to be increased.  Third, the timeout
> > necessary for multiple-master arbitration is larger than the timeout for basic
> > read/write operations, so we shouldn't have a single constant for both timeouts.
> > Finally, it would be nice if we could override these values on a per-board
> > basis.
> > 
> > Signed-off-by: Timur Tabi <timur at freescale.com>
> > ---
> >  drivers/i2c/fsl_i2c.c |   24 ++++++++++++++++++++----
> >  1 files changed, 20 insertions(+), 4 deletions(-)
> 
> Acked-by: Wolfgang Denk <wd at denx.de>

Tested-by: Peter Tyser <ptyser at xes-inc.com>
Acked-by: Peter Tyser <ptyser at xes-inc.com>

Looks good to me,
Peter