[U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable

Heiko Schocher hs at denx.de
Sun Sep 6 11:09:54 CEST 2009


Hello Timur,

Timur Tabi wrote:
> The value of I2C_TIMEOUT in fsl_i2c.c has several problems.  First, it is
> defined as CONFIG_HZ/4, but it is used as a count of microseconds, so it makes
> no sense to derive it from a clock rate.  Second, the current value (250) is
> too low for some boards, so it needs to be increased.  Third, the timeout
> necessary for multiple-master arbitration is larger than the timeout for basic
> read/write operations, so we shouldn't have a single constant for both timeouts.
> Finally, it would be nice if we could override these values on a per-board
> basis.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
>  drivers/i2c/fsl_i2c.c |   24 ++++++++++++++++++++----
>  1 files changed, 20 insertions(+), 4 deletions(-)

Applied to u-boot-i2c.git

Thanks for your work,

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list