[U-Boot] [PATCH] ppc/85xx: Use CONFIG_SYS_MONITOR_LEN in linker script

Wolfgang Denk wd at denx.de
Wed Sep 9 15:55:22 CEST 2009


Dear Kumar Gala,

In message <1252503014-3651-1-git-send-email-galak at kernel.crashing.org> you wrote:
> Now that we set CONFIG_SYS_MONITOR_LEN properly we can use it and
> TEXT_BASE to ensure that the boot page and reset vector are placed at
> the proper location in the u-boot image.
> 
> We needed to cleanup the use of a C++ comment in P1_P2_RDB.h to allow
> use of config.h in u-boot.lds.

I think this is bound to be a continuous source of trouble, as you
suddenly have two different config items (TEXT_BASE and
CONFIG_SYS_MONITOR_LEN) which must be kept in sync. This is
definitely not good.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Look! There! Evil!.. pure and simple, total  evil  from  the  Eighth
Dimension!"                                         - Buckaroo Banzai


More information about the U-Boot mailing list