[U-Boot] [PATCH v2] Support for the OpenRD base board

[Prafulla Wadaskar]

> -----Original Message-----
> From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net] 
> Sent: Friday, September 11, 2009 5:48 PM
> To: Prafulla Wadaskar
> Cc: U-Boot ML; Dhaval Vasa; Prabhanjan Sarnaik; Ashish Karkare
> Subject: Re: [PATCH v2] Support for the OpenRD base board
> 
> Thanks for the comments Prafulla!
> 
> I'll update the patch according to them, but have some questions:
> 
> On Fri, 11 Sep 2009 03:43:04 -0700
> Prafulla Wadaskar <prafulla at marvell.com> wrote:
> 
> > > +#define CONFIG_ENV_SIZE                      0x20000 /* 128k */
> > > +#define CONFIG_ENV_ADDR                      0xa0000
> > > +#define CONFIG_ENV_OFFSET            0xa0000 /* env 
> starts here */
> > Do you really need this address? the u-boot binary is 
> within 256kb, at the most it can go till 512kb
> 
> This is where the default environment (for the U-boot shipped by
> Marvell) resides. Like on Sheevaplug, it uses 4-bit ECC, so current
> U-boot won't be able to read it, but I know you're working on it.
So I think, you want to retain both environment variables untouched
 ( i.e. latest u-boot and u-boot shipped by Marvell)
But so far as mainlined u-boot is considered,
doesn't it make sense to pack uboot-bin and environment sector together?
like sheevaplug, I think first 2 sectors for u-boot and next once sector for env should be better to choose.

> 
> > > +#define MTDIDS_DEFAULT               "nand0=nand_mtd"
> > > +#define MTDPARTS_DEFAULT
> > > "mtdparts=nand_mtd:0x100000 at 0x000000(uboot),0x400000 at 0x100000(
> > > uImage),"\
> > > +     "0x1fb00000 at 0x500000(rootfs)"
> > This is must be the default setup in board setup file for 
> openrd_base (if it is again derived from sheevaplug)
> > In that case this settings not required
> 
> I don't quite understand this. This is also the default addresses
> shipped with the board.
W..r.to line 24 at http://git.marvell.com/?p=orion.git;a=blob;f=arch/arm/mach-kirkwood/openrd_base-setup.c;h=947dfb8cd5b252bf326d691ee5179e29ad07a9a9;hb=HEAD
By default kernel has same mdtpart configuration as you are describing here.
So you don't need this default setup here, you should skip it

> 
> > > +#define CONFIG_EXTRA_ENV_SETTINGS    "x_bootargs=console"    \
> > > +     "=ttyS0,115200 "MTDPARTS_DEFAULT " rw ubi.mtd=2,2048\0" \
> > > +     "x_bootcmd_kernel=nand read 0x6400000 0x100000 0x300000\0" \
> > > +     "x_bootcmd_usb=usb start\0" \
> > You must add x_bootcmd_eth for program MAC addrss in 
> hardware before kernel boot.
> 
> Well, we need to figure out some generic way of giving Linux the MAC
> address on these boards, but I've understood that initializing the
> interface without using it is not popular, so in this case 
> I'd just let
> the problem remain (no x_bootcmd_eth).
Okay,

> 
> Or did I misunderstand your comment?
No you understood it properly

As per my knowledge, I don't this the any hack for this in kernel will be accepted.
The same is with u-boot arm net drivers.
At both places fingures are crossed. s/w guys thinks h/w should take care of this.
But unfortunately this is not happening with this h/w (may be there are few more).
I personally feel that u-boot should handle this (copying ben for this)

Regards..
Prafulla . .

> 
> // Simon
>