[U-Boot] [PATCH 4/5] mpc83xx: mpc8360emds: Use RGMII mode, add workarounds for rev. 2.1 CPUs

Anton Vorontsov avorontsov at ru.mvista.com
Sat Sep 19 01:29:17 CEST 2009


On Fri, Sep 18, 2009 at 05:40:45PM -0500, Kim Phillips wrote:
> On Wed, 16 Sep 2009 23:21:59 +0400
> Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
> 
> > This patch fixes various ethernet issues with gigabit links handling
> > in U-Boot. The workarounds originally implemented by Kim Phillips for
> > Linux kernel.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
> > ---
> 
> sorry, can't accept - this breaks r1.1 based boards:

Oops. Thanks a lot for testing.

I think I know why it breaks, we should use RGMII_ID for < 2.1
revs (at least that's what we have in Linux by default). I don't
have r1.1 CPUs, can you please try this patch on top of the
current patch set?

If it'll work, I'll repost a fixed version of this patch.

diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h
index dab0173..62cf13b 100644
--- a/include/configs/MPC8360EMDS.h
+++ b/include/configs/MPC8360EMDS.h
@@ -399,7 +399,7 @@
 #define CONFIG_SYS_UEC1_TX_CLK		QE_CLK9
 #define CONFIG_SYS_UEC1_ETH_TYPE	GIGA_ETH
 #define CONFIG_SYS_UEC1_PHY_ADDR	0
-#define CONFIG_SYS_UEC1_INTERFACE_MODE ENET_1000_RGMII
+#define CONFIG_SYS_UEC1_INTERFACE_MODE ENET_1000_RGMII_ID
 #endif
 
 #define CONFIG_UEC_ETH2		/* GETH2 */
@@ -410,7 +410,7 @@
 #define CONFIG_SYS_UEC2_TX_CLK		QE_CLK4
 #define CONFIG_SYS_UEC2_ETH_TYPE	GIGA_ETH
 #define CONFIG_SYS_UEC2_PHY_ADDR	1
-#define CONFIG_SYS_UEC2_INTERFACE_MODE ENET_1000_RGMII
+#define CONFIG_SYS_UEC2_INTERFACE_MODE ENET_1000_RGMII_ID
 #endif
 
 /*


More information about the U-Boot mailing list