[U-Boot] [PATCH v3 1/3] NAND boot: MPC8536DS support

[Hu Mingkai-B21284]

> -----Original Message-----
> From: Liu Dave-R63238 
> Sent: Saturday, September 19, 2009 8:01 AM
> To: Kumar Gala; Hu Mingkai-B21284
> Cc: Wood Scott-B07421; u-boot at lists.denx.de
> Subject: RE: [U-Boot] [PATCH v3 1/3] NAND boot: MPC8536DS support
> 
> > > diff --git a/cpu/mpc85xx/cpu_init_nand.c
> 
> > > +void cpu_init_f(void)
> > > +{
> > > +	ccsr_lbc_t *lbc = (void *)(CONFIG_SYS_MPC85xx_LBC_ADDR);
> > > +
> > > +	/*
> > > +	 * LCRR - Clock Ratio Register - set up local bus timing
> > > +	 * when needed
> > > +	 */
> > > +	out_be32(&lbc->lcrr, LCRR_DBYP | LCRR_CLKDIV_8);
> > > +
> > > +#if defined(CONFIG_NAND_BR_PRELIM)  \
> > > +	&& defined(CONFIG_NAND_OR_PRELIM)
> > > +	out_be32(&lbc->br0, CONFIG_NAND_BR_PRELIM);
> > > +	out_be32(&lbc->or0, CONFIG_NAND_OR_PRELIM);
> > > +	/* for FPGA */
> > > +	out_be32(&lbc->br3, CONFIG_SYS_BR3_PRELIM);
> > > +	out_be32(&lbc->or3, CONFIG_SYS_OR3_PRELIM); #else #error  
> > > +CONFIG_NAND_BR_PRELIM, CONFIG_NAND_OR_PRELIM must
> > be defined
> > > +#endif
> > > +
> > 
> > Should we not have br/or1, br/or2, etc?
> > 
> 
> And FPGA stuff put here cpu/mpc85xx.....
> It is *not* good practice and should be move out from here.
> I know the FPGA is for UART clock.
> 

Yes, it's only used for getting the SYSCLK. Where should we put it to?
to the nand_spl/board/freescale/mpc8536ds/nand_boot.c?

Thanks,
Mingkai