[U-Boot] [PATCH v3 1/3] NAND boot: MPC8536DS support

[Dudhat Dipen-B09055]

Hi Liu,

I have posted the patch for the same.
Have a look at the attachment.

Thanks
Dipen


-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
On Behalf Of Liu Dave-R63238
Sent: Saturday, September 19, 2009 5:31 AM
To: Kumar Gala; Hu Mingkai-B21284
Cc: Wood Scott-B07421; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH v3 1/3] NAND boot: MPC8536DS support

> > diff --git a/cpu/mpc85xx/cpu_init_nand.c

> > +void cpu_init_f(void)
> > +{
> > +	ccsr_lbc_t *lbc = (void *)(CONFIG_SYS_MPC85xx_LBC_ADDR);
> > +
> > +	/*
> > +	 * LCRR - Clock Ratio Register - set up local bus timing
> > +	 * when needed
> > +	 */
> > +	out_be32(&lbc->lcrr, LCRR_DBYP | LCRR_CLKDIV_8);
> > +
> > +#if defined(CONFIG_NAND_BR_PRELIM)  \
> > +	&& defined(CONFIG_NAND_OR_PRELIM)
> > +	out_be32(&lbc->br0, CONFIG_NAND_BR_PRELIM);
> > +	out_be32(&lbc->or0, CONFIG_NAND_OR_PRELIM);
> > +	/* for FPGA */
> > +	out_be32(&lbc->br3, CONFIG_SYS_BR3_PRELIM);
> > +	out_be32(&lbc->or3, CONFIG_SYS_OR3_PRELIM); #else #error  
> > +CONFIG_NAND_BR_PRELIM, CONFIG_NAND_OR_PRELIM must
> be defined
> > +#endif
> > +
> 
> Should we not have br/or1, br/or2, etc?
> 

And FPGA stuff put here cpu/mpc85xx.....
It is *not* good practice and should be move out from here.
I know the FPGA is for UART clock.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

-------------- next part --------------
An embedded message was scrubbed...
From: "Dudhat Dipen-B09055" <Dipen.Dudhat at freescale.com>
Subject: [ubootdev] [PATCH v1]ppc/85xx/NAND:Check to program BR3/OR3 required or not
Date: Fri, 18 Sep 2009 19:21:57 +0530
Size: 2728
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090920/5f38317b/attachment.eml