[U-Boot] [PATCH v3] at91: Update MEESC board support

Wolfgang Denk wd at denx.de
Tue Sep 22 20:45:38 CEST 2009


Dear Daniel Gorsulowski,

In message <12525916852655-git-send-email-Daniel.Gorsulowski at esd.eu> you wrote:
> This patch implements several updates:
> -disable CONFIG_ENV_OVERWRITE
> -add new hardware style variants and set the arch numbers appropriate (autodet.)

LIne too long.

> -pass the serial# and hardware revision to the kernel
> -removed unused macros from include/configs/meesc.h
> 
> Signed-off-by: Daniel Gorsulowski <Daniel.Gorsulowski at esd.eu>
...
> --- a/board/esd/meesc/meesc.c
> +++ b/board/esd/meesc/meesc.c
> @@ -156,8 +156,35 @@ int board_eth_init(bd_t *bis)
>  int checkboard(void)
>  {
>  	char str[32];
> -
> -	puts("Board: esd CAN-EtherCAT Gateway");
> +	u_char hw_type;	/* hardware type */
> +
> +	/* read the "Type" register of the ET1100 controller */
> +	hw_type = readb(CONFIG_ET1100_BASE);
> +
> +	switch (hw_type) {
> +		case 0x11:
> +		case 0x3F:

Incorrect indentation - the "case" must have the same indent as the
"switch". Please fix globally.

> +			/* ET1100 present,
> +			   arch number of MEESC-Board */

Incorrect multiline comment style. Please fix globally.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lots of people drink from the wrong bottle sometimes.
	-- Edith Keeler, "The City on the Edge of Forever",
	   stardate unknown


More information about the U-Boot mailing list