[U-Boot] [PATCH] ppc4xx: Netstal boards: various cleanups

Wolfgang Denk wd at denx.de
Wed Sep 23 20:55:40 CEST 2009


Dear Niklaus Giger,

In message <1253719369-26565-3-git-send-email-niklaus.giger at netstal.com> you wrote:
> Various cleanups for our boards:
> - vxworks_preboot to get clock input right for HCU4/MCU25
> - reboot if SW-install-input is activated
> - clear vxWorks exception msg
> - HCU5: various HW-registers updated
> - HCU5: 2nd Ethernet = SMII,  Ethernet PLL Config. = recommended values
> - HCU5: PATCH HAB: WRITE PIPELINING OFF
> - HCU5: no pci_init if board has no PCI
> - MCU25: corrected address to read slot id
> - Lindent -pcs for hcu5.c

Please don't mix white space cleanup / formatting changes with changes
of real content.

> +void show_activity(int arg)
> +{
> +	hcu_led_set(arg);
> +	if( sys_install_requested() !=installRequested )
> +	{
> +		printf("%s: installRequested 0x%x 0x%x\n", __FUNCTION__,
> +		       installRequested,
> +		       sys_install_requested());
> +		do_reset ();
> +	}

Incorrect brace style. Please fix globally.

...
> diff --git a/board/netstal/hcu5/sdram.c b/board/netstal/hcu5/sdram.c
> index 0546cd7..d52cf99 100644
> --- a/board/netstal/hcu5/sdram.c
> +++ b/board/netstal/hcu5/sdram.c
> @@ -36,9 +36,11 @@
>  #include <asm/mmu.h>
>  #include <asm/cache.h>
>  #include <ppc440.h>
> +#include <post.h>
>  
>  void hcu_led_set(u32 value);
>  void dcbz_area(u32 start_address, u32 num_bytes);
> +void zero_all_memory(unsigned long start_address, unsigned long num_bytes);
>  
>  #define ECC_RAM				0x03267F0B
>  #define NO_ECC_RAM			0x00267F0B
> @@ -48,6 +50,11 @@ void dcbz_area(u32 start_address, u32 num_bytes);
>  #define MY_TLB_WORD2_I_ENABLE TLB_WORD2_I_ENABLE
>  	/* disable caching on DDR2 */
>  
> +/* PPC440EPx Erratum CHIP_11: End of memory range area restricted access.
> + *    -> no access to last 256 Bytes!!!
> + */

Incorrect multiline comment style. Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The one charm of marriage is that it makes a  life  of  deception  a
neccessity."                                            - Oscar Wilde


More information about the U-Boot mailing list