[U-Boot] [PATCH v4 1/7] ppc/p4080: Add p4080 platform immap definitions

Wolfgang Denk wd at denx.de
Wed Sep 23 22:52:51 CEST 2009


Dear Kumar Gala,

In message <19E9B551-F442-4BA2-98A3-C941620E4E64 at kernel.crashing.org> you wrote:
> 
> Dope, posted the wrong version.  I agree w/the long lines, not sure  
> what to do about it.  Move to something like:
> 
> typedef struct ccsr_local {
> 	/* 0x0 - Control Configuration Status Registers Base Address Register  
> High */
> 	u32	ccsrbarh;	
> 	/* 0x4 - Control Configuration Status Registers Base Address Register  
> Low */
> 	u32	ccsrbarl;	
> 
> ...
> 
> even this exceeds the 80 column limit.

Why do you need to carry the offset in the comment?

What about:

Control Config Status Regs Base Addr Reg ?

or

BAR = Base Address Register (once initially)

Control Config Status Regs BAR ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is an illusion perpetrated by the manufacturers of space.


More information about the U-Boot mailing list