[U-Boot] [PATCH 1/1] TI OMAP3 Use arm init sequence to initialize i2c

Heiko Schocher hs at denx.de
Mon Sep 28 07:46:31 CEST 2009


Hello Dirk,

Dirk Behme wrote:
> Heiko Schocher wrote:
>> Hello Tom,
>>
>> Tom Rix wrote:
>>> This changes fixes an early i2c error.
>>>
>>> It appears that I2C is working because once a read or write
>>> error is detected, the omap24xx_i2c driver calls i2c_init
>>> inside its error handling check.
>>>
>>> While it is ok to attempt error handling this way, the boards
>>> must not depend on this side effect to initialize it's i2c.
>>>
>>> Instead of explicitly calling i2c_init for every board, use
>>> the generic arm initialization in lib_arm/board.c. By defining
>>> the config variable CONFIG_HARD_I2C, the omap3 i2c initialization
>>> is included in the init_sequence table.
>>>
>>> Run tested on Beagle.
>>> Compile tested on the omap3's
>>>
>>> Signed-off-by: Tom Rix <Tom.Rix at windriver.com>
>>> ---
>>
>> Patch does not apply:
> 
> It seems that it applies to u-boot-ti. Is it ok to move it through
> u-boot-ti into mainline?

This is okay for me, so I just make:

Acked-by: Heiko Schocher<hs at denx.de>

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list