[U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

Wolfgang Denk wd at denx.de
Wed Sep 30 23:47:46 CEST 2009


Dear "Paulraj, Sandeep",

In message <0554BEF07D437848AF01B9C9B5F0BC5D92EC0C2F at dlee01.ent.ti.com> you wrote:
> 
> > > Why? It is not really important here, but especially when mixing data
> > > types, TABs are preferred, as they will allow for nice vertical
> > > alignment.
> > 
> > OK. TABs are preferred.
> > 
> > The structure defined below it used a single space.
> > When looked at together, it seemed to me to be inconsistent.
> > 
> > Tom
> What do about this patch. You ACK'ed it
> Do you want me to revert to the original patch ?

No. Please leave as is. The difference really is not important here.

I just did not understand why the change was requested in the first
place, but now it has been done, we should not throw even more efforts
on it.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Pull the wool over your own eyes!"                - J.R. "Bob" Dobbs


More information about the U-Boot mailing list