[U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

[Tom]

Paulraj, Sandeep wrote:
>> Wolfgang Denk wrote:
>>> Dear Tom,
>>>
>>> In message <4AC1FE5C.4070503 at windriver.com> you wrote:
>>>>> +struct davinci_gpio {
>>>>> +	unsigned int	dir;
>>>>> +	unsigned int	out_data;
>>>>> +	unsigned int	set_data;
>>>>> +	unsigned int	clr_data;
>>>>> +	unsigned int	in_data;
>>>>> +	unsigned int	set_rising;
>>>>> +	unsigned int	clr_rising;
>>>>> +	unsigned int	set_falling;
>>>>> +	unsigned int	clr_falling;
>>>>> +	unsigned int	intstat;
>>>>> +};
>>>> Convert the tabs to spaces in the in the whitespace between
>>>> type and elemement names
>>>> unsigned int	dir; -> unsigned int dir;
>>>> For all of the elements
>>> Why? It is not really important here, but especially when mixing data
>>> types, TABs are preferred, as they will allow for nice vertical
>>> alignment.
>>>
>> OK. TABs are preferred.
>>
>> The structure defined below it used a single space.
>> When looked at together, it seemed to me to be inconsistent.
>>
>> Tom
> What do about this patch. You ACK'ed it
> Do you want me to revert to the original patch ?

I will defer to Wolfgang on this.
Since I caused the problem, I will fix it.
Tom

> 
>>> Best regards,
>>>
>>> Wolfgang Denk
>>>
>