[U-Boot] [RFC] PPC: post_word_{load/store} - eliminate redundant code

Stefan Roese sr at denx.de
Wed Apr 21 06:30:27 CEST 2010


Hi Wolfgang,

On Tuesday 20 April 2010 23:39:09 Wolfgang Denk wrote:
> > In order to eliminate redundant code for powerPC architecture when
> > defining post_word_{load/store} routines I suggest  moving them into
> > the arch/ppc/lib/commproc.c file rather than adding them to every
> > arch/ppc/cpu/XXXX.
> 
> NAK. The commproc.* files are supposed to contain code dealing with
> the PowerQUICC Communication Processor Modules. This is in no way the
> right place for common code.
> 
> Stefan - arch/ppc/cpu/ppc4xx/commproc.c  makes no sense - can we
> please clean this up?

Yes, I'll take a look at it.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list